Client implementation #1
Conversation
| impl From<DisperserG1Commitment> for G1Commitment { | ||
| fn from(value: DisperserG1Commitment) -> Self { | ||
| Self { | ||
| x: value.x, | ||
| y: value.y, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there any point in redefining G1Commitment here? Its literally the same struct as the one in generated/common.rs. Perhaps we can just use that one directly?
Change anyhow for thiserror
Sync latest changes
|
hey @samlaf this is ready for review again, we merged the previous PRs (the one about thiserror and the other one that synced the latest changes). Let me know if you have any questions. |
There was a problem hiding this comment.
@juanbono @gianbelinche are you guys ready to start using this client in zksync after we merge this PR? If so then I don't want to delay this merge any longer. I can just create separate issues for the points raised below that we can fix in separate PRs.
src/generated/common.rs
Outdated
There was a problem hiding this comment.
how were these generated? can we use a submodule to eigenda + prost to generate these?
src/sdk.rs
Outdated
There was a problem hiding this comment.
I'm not a huge fan of the module name sdk.
What is the reason why client and RawEigenClient need to be separate? Most of the methods in RawEigenClient are private anyways right? So could we not just merge the two?
There was a problem hiding this comment.
I think we can address that one in a separate PR after we merge this initial implementation
This PR moves the client implementation coming from zksync-era.
It has some changes to make it work as a lib: